faq-accordion-card using html, sass, bootsrap and javascript

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi

  This would be really great if you

  • made it keyboard interactive by using interactive elements for event listener items
  • used js to add / remove classes instead of inline styles
  • used css properties that can be transformed (display can't, but opacity, height etc can) which would allow you to add simple css animation effects
  • tweaked the styles on mobile so you can always see the image at the top and all content, even when mobiles are small or viewed landscape
  • changed body height to min-height
  • either didn't absolutely position your footer attribution, or added enough padding to the bottom of the body to ensure that footer never overlaps the main page content.

  I hope these tips are helpful, best of luck with it

  2

  ---

  

  Shashank Gupta•195

  @Shashank1003Posted almost 4 years ago

  @grace-snow I understood your points and will try to incorporate them in future projects. These tips are really helpful as I was searching for ways to make websites look much pretty and interactive. Thanks a lot.

  0
• 

  Gustavo "Piá" de Moraes Xavier•25

  @piagjaPosted almost 4 years ago

  nice work man!

  one thing besides the tips of colleagues above is to add some easing when clicking in the arrow. Like arrow.element { transition: all 0.6s ease-in-out; }

  1

  ---

  

  Shashank Gupta•195

  @Shashank1003Posted almost 4 years ago

  @piagja Yes, I was also thinking that click feels different on my site. Thanks for the solution 😊

  1