FAQ-accordion using React and Bootstrap

Community feedback

• 

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  Hello there, Congratulations on completing this project

  Your solution looks nice

  I have few suggestions that I think might be of interest to you.

  - HTML: Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <div class="card"> with <main class="card">. the main tag should hold the main content of the page so consider correcting that.

  The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div hold no semantic value.

  Also the background image is just for decoration and you didn't have to use div for it. Instead use css background: url() property for the background image. In this situation you could do

  background: url(./image-path) top/contain no-repeat;
  

  using the above code position the image at the top and give it a background-size property of contain with a background-repeat property of no-repeat

  I hope this feedback is helpful

  Other than that great job

  Marked as helpful

  0

  ---

  

  Advyta Jujaray•170

  @AdvytaPosted 10 months ago

  @Zukizuk Thanks for the feedback I'll keep it in mind for my next project.

  0