Skip to content
Submitted 12 months ago

FAQ-accordion Developed in CSS and JS

CMP2007•210
@CMP2007
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Do you notice an error or have any recommendations regarding CSS styles?

Do you have any suggestions regarding the repository or the solution?

What aspect do you think should be improved for future occasions?

Do you think that the js functionality has a correct approach?

Community feedback

  • JimTK16•370
    @JimTK16Posted 12 months ago

    Hi CMP,

    That's a smart attempt to swap out the icon in your JS. A thing that i notice is that you also have an id on your icon which is the same as the id you set for the details element. I think id should be unique for elements ( two elements shouldn't have the same id). I believe that you can remove the id on your icons and the app still works as you expected.

    Jim

    Marked as helpful
    0
    CMP2007•210
    @CMP2007Posted 12 months ago

    Hi @JimTK16,

    You are right, I incorrectly incorporated repetitive identifiers for the icons, I have already uploaded the correction to the repository.

    Thank you very much for your time and your comment.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord