Design comparison
Solution retrospective
This is my second FrontendMentor project, and it's really useful for me and I learned a lot. Any suggestions on how I can improve are welcome!
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there π. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
- The content should expand when clicking on the paragraph, not just the icon. Additionally, you can implement a design where the user sees a change when hovering over the paragraph. Also, consider adding hover styles for better user feedback, as shown in the "active-states.jpg" image.
- You should use the
cursor: pointer
property to indicate that the element is clickable.
- Elements that perform an action, such as opening an accordion, should be buttons to allow users to access them through the keyboard. Also, note that <span> is not an interactive element.
- Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source π
I hope you find it useful! π
Happy coding!
1 - @danielmrz-devPosted 11 months ago
Hello @Ehsan-eslami!
Your project looks excellent!
I have just one suggestion:
- If you change the body
background-color
to#FAEEFF
, it'll look even closer to the original design.
I hope it helps!
Other than that, great job!
0@Ehsan-eslamiPosted 11 months agoMany thanks @danielmrz-dev :) I will definitely apply the mentioned changes.
1@Ehsan-eslamiPosted 11 months agoHey @danielmrz-dev I apply changes that you mentioned. Any other suggestion? :)
1@danielmrz-devPosted 11 months ago@Ehsan-eslami
No, it's great!
Just generate a new screenshot π
Glad my comment was helpful!
1 - If you change the body
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord