FAQ Card

Community feedback

• 

  Gilberto Fernández•60

  @gfernan24373Posted over 2 years ago

  Hey!! nicely done!!! I gonna submit this challenge in a couple of hours, it was so hard but no imposible positioning the @ box, you can use position relative and absolute with relative values for the properties like width, height and the position for the top, botton, right and left. Feel free to review this material that I founded to solve this issue https://codepen.io/graup/pen/EPjNwr.

  In the JS document you can set the properties for the faqs answers in this case p tags. I don't know why the js script file cannot read the properties in the css files directly. I founded sites explaining the getComputedStyle and getPropertyValue methods to read the properties in the .css file but looks to hard to implement. if you select a p tag like this in the js file:

  let faqs = document.querySelectorAll('.p-faq'); //Select all the p tags for (answer of faqs) { console.log(answer.style.display): } //Console =

  So... All the properties are empty and you need to set it again like this: for (answer of faqs) { answer.style.display = 'none'; } . . ...rest of the code here And now, you can do whatever you want.

  Marked as helpful

  0
• 

  Christian Foster•270

  @fosteecoPosted over 2 years ago

  The way I'd fix this is by creating a wrapper around the main tag with the same width. .main-wrapper { position: relative; width: min(100% - 8rem, 920px); } This container wraps around the main tag so it's like this:

  <div class="main-wrapper"> <main class="container">...</main> </div>

  This should fix the issue. I created a pull request on your repo if you want to try this solution. Looks good though.

  One thing I think is an issue is the pulldowns extending the size of the container on smaller screens when they are opened. It seems kind of jarring.

  Marked as helpful

  0

  ---

  

  Trey•290

  @willettoPosted over 2 years ago

  @fosteeco Hmm, I think this would work, but doesn't look very clean. I might try your idea, but using the ::after psuedo-element instead. I'm pretty sure it acts in a similar way to wrapping it.

  And I agree that the pulldowns changing the size is abrupt, that's why I want to add a transition/slide-in effect. I think that & maybe adding a touch more space will solve the issue. Thanks for your feedback!

  0
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted over 2 years ago

  Don't forget to add the box shadow to the main container

  Marked as helpful

  0

  ---

  

  Trey•290

  @willettoPosted over 2 years ago

  @Kamasah-Dickson It shows up in the mobile orientation and I didn't even notice that it disappeared on the desktop version. I'll have to figure that one out. Thanks!

  0
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted over 2 years ago

  The img should have a position property of relative.

  And the box should have a position absolute Remember both the box and IMG should be in the same container.

  Also to the drop down it should have a height of 0px and visibility hidden.

  After that do something like this

  h1:active + p { height:the height u want; visibility: visible; }

  Create a CSS transition
  E.g @keyfram trans { NB: the "from" and "to" from{ opacity:0; Something else }

  To{ Opacity: Something else } }

  Don't forget to add the trans to the element u want to transit So your element { Transition trans 3s eas linear; }

  I hope u get it or u can learn from the link below

  https://www.w3schools.com/cssref/css3_pr_animation-keyframes.asp

  Happy coding👍

  1