Faq Card || CSS/JS Vanilla || Unfinished

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ACCORDION 🔴 :

  • The best way to go with creating the accordion elements in this challenge would be with the details and summary elements (or perhaps a combination of buttons and other elements).

  ---

  • They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the div & p elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.

  ---

  • MDN's reference is a great place to start learning about the details and summary elements if you are interested.

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Sebastian Frampton•400

  @sebframptonPosted over 1 year ago

  Hi Edevando,

  Really good design. I like the arrow animation.

  So, with the responsive.css were you have @media screen and (max-width: 1439px) and @media screen and (min-width: 1440px) which works mobile friendly which is great! but it is too wide in px length so it is showing mobile view. It really should be the desktop version.

  Change it to a more lower pixel 1024×768px instead of 1440px on both of them.

  I noticed to that your desktop logo isn't popping to the left of the content.

  Add some margin to your boxImgDesktop #exampleBoxImage { margin-left: -13px; margin-bottom: 13px; }

  Hope this helps =)

  Thanks for sharing

  Marked as helpful

  1

  ---

  

  Edevando Alves•70

  @EdEddAEddyPosted over 1 year ago

  @sebframpton Thanks, I really had some problems with this, I'll see if I can fix it.

  1