Design comparison
SolutionDesign
Solution retrospective
I would greatly appreciate any feedback. 🚀
Community feedback
- @VCaramesPosted over 1 year ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
figure
,figcaption
andsection
elements are being used incorrectly ⚠️ and not needed for this challenge.
- The “illustrations/icons” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Your accordion is NOT accessible⚠️. Since your are using JS to open/close your accordion, you need use
buttons
and they need to havearia-expanded
to show the answers.
More Info: 📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 👾
Marked as helpful1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord