Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FAQ card

@rStrzelczyk98

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would greatly appreciate any feedback. 🚀

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The figure, figcaption and section elements are being used incorrectly ⚠️ and not needed for this challenge.
  • The “illustrations/icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank to hide them from assistive technology.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • Your accordion is NOT accessible⚠️. Since your are using JS to open/close your accordion, you need use buttons and they need to have aria-expanded to show the answers.

More Info: 📚

A11Y Style Guide: Accordion

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 👾

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord