Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I have completed this challenge in one go. I thnik I can now understand how to start building with CSS without panicking
What challenges did you encounter, and how did you overcome them?Had some problem with the background positioning. Then I solved it
Community feedback
- @ChamuMutezvaPosted 2 months ago
Hi Nasif Fuad
So far so good with your project, but here is my take:
- One of the building blocks of a website are
Landmark
elements, whichprovide a powerful way to identify the organization and structure of a web page
- this is very useful for assistive technology users as information will be conveyed. Such elements includemain, header and footer
. For this project I would use the div with the classwrapper
as the main element. - This challenge requires interactive elements since it involves what is known as the disclosure pattern. EventListeners can only work effectively with elements such as buttons, an image is not an interactive element - hence it should not be associated with eventListeners. In other words , use semantic elements.
- Separation of concerns - let your html , your css and your JS be on separate files . You have some inline styles in your html and that can complicate maintainability if bigger projects. The use of the
!important
is something that should be avoided as well. - For font sizes , at least you should use
rems
, using px has some disadvantages as explained in the attached article - Why font-size must NEVER be in pixels
Hope that helps
Marked as helpful1@NasifuadPosted 2 months ago@ChamuMutezva Thank you so much for pointing out this to me.
0 - One of the building blocks of a website are
- @abdellah-abadouPosted 2 months ago
Your JavaScript codes are working and this is the most important, but there are better ways to implement the task
1@NasifuadPosted 2 months ago@abdellah-abadou I have made a function for the toggleDisplay to reduce JS
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord