FAQ Accordion with no JS

Community feedback

• 

  ezecoder•870

  @3eze3Posted over 1 year ago

  Hello name, good result with this challenge, I have some questions you may find useful. Scss:

  • Instead of using the "@import" rule in the main.scss file to import partials, it is recommended to migrate to the "@use" rule. The "@use" rule provides greater flexibility and more effective scoping compared to the discontinued "@import" rule.

  • It would be highly beneficial to consider using mixins for repetitive styles, such as media queries and flexible layouts using flex layout. This strategy allows for cleaner code and centralizing repetitive styles within mixins, which creates better code organization.

  • It has been observed that, in the interaction with the details of each block, multiple blocks can be allowed to open simultaneously without closing the previous ones. This behavior can negatively affect the page layout. It is suggested to apply a "max-height" property to the corresponding container to avoid possible mismatches when opening a block and, in this way, maintain consistency in the design.

  JavaScript:

  • In addition, one could consider implementing a class system that, when opening a block, removes the classes in the other blocks, so that they are automatically closed. This solution would add an additional level of control and ensure a more consistent interaction.

  Happy coding 🍞

  Marked as helpful

  0

  ---

  

  Amir Hashemi•480

  @AmirhosseinHashemiPosted over 1 year ago

  @3eze3 hello my friend

  Thanks a lot for your useful help.

  • I will use your tip in my next challenge.
  • about using mixins I think increase mixins make code messy so when I use mixins that decrease considerable lines my code.
  • After that I will apply specific height for question block it's really bad for layout.

  happy coding :)

  0