FAQ Accordion with HTML, CSS, React

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 11 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ACCORDION 🔴 :

  • I want to express my applause for the efforts you've taken to convert design image into working code for this challenge, Your designing skill is great apart from that you need to focus on improving accessibility.

  ---

  • The accordions needs be re-written with semantic markup, The best way to go with creating the accordion elements in this challenge would be with the details and summary elements (or perhaps a combination of buttons and other elements).

  ---

  • They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the div & p elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.

  ---

  • MDN's reference is a great place to start learning about the details and summary elements if you are interested.

  ---

  • If you have any questions or need further clarification, you can always check out my submission for legacy version of this challenge and/or feel free to reach out to me.

  ---

  • Another thing is you have forgotten to add pointer for accordions, so please do add cursor: pointer so that user's can know that the accordions are interactable.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Cristi Gutierrez•50

  @justbycrisPosted 11 months ago

  Hi Raine, Great job with your project! I had similar questions when doing mine. I did just one open question at a time, so when the user would try to open another one, the current one would close. I'm still figuring out the animation to open then as well, I'm thinking of a sliding effect. I did my first solution on this with JS, but redoing it with React now, so I guess I have much to figure out haha

  Keep it up!

  0