Design comparison
SolutionDesign
Solution retrospective
Any feedback would be appreciated <3
Community feedback
- @rsrclabPosted almost 3 years ago
Hi, @NADS-PROGRAMMER ~ Congratulate on your solution to the challenge. I have studied your solution and learned a lot from it. Here are some of the tips I recommend on this one.
- I think using BEM structure on this one could help scss to be more comfortable.
- Accordion effect - I think transition could make things more wonderful.
- About positioning of card, now it is shrinking when accordion items slides down, I think fixing it's top by giving margin-top or padding-top could be better, so that panel expands only downwards.
Hope this can help you even a bit. Happy coding ~
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord