Design comparison
Solution retrospective
Feedbacks are most welcome.
Thanks
Happy Coding
Community feedback
- @isprutfromuaPosted over 2 years ago
Hi there. You did a good job 😎
keep improving your programming skills🛠️
your solution looks great, however, if you want to improve it, you can follow these steps:
✅ improve accessibility. Sorry, but I can't navigate through your site using keyboard. One of easiest way to improve it: use buttons instead of div .
<button onClick={handleonClick} className="faq__header"> <p className="cursor-pointer hover:text-red" > {data.question} </p> <Arrow className="cursor-pointer" /> </button>
✅ dont use BEM with tailwind. On my opinion it's bad idea. it is not clear in which direction you will further expand your application
✅ Remove debugging code . There is no reason to store it in the repository
console.log(dataArr);
I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated
Good luck and fun coding 🤝⌨️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord