Design comparison
Solution retrospective
I have solved this challenge before using vanilla JS. This is my solution using React
However, there is a bug in my code. When the page is first loaded , and with the first click on any question, the question toggles correctly. But after that, I need to click twice on each question to toggle and I don't know why !!.
My code is not good for such simple functionality. I would apprecicate feedback on how to fix the bug and improve my code.
Thank.
Community feedback
- @javascriptor1Posted 9 months ago
UPDATE
I have fixed the problem in my code. Its working fine now.
0 - @Alokray007Posted 9 months ago
Hello there š
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
š Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord