Abdul Khaliq πβ’ 72,580
@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have a recommendation regarding your code that I believe will be of great interest to you.
ACCORDION π΄ :
- Currently the FAQs are need to be toggled using JavaScript right?, But the best way to go with creating the accordion elements in this challenge would be with the
details
andsummary
elements (or perhaps a combination of buttons and other elements).
- They are accessible and will provide a clean, semantic way to create accordion elements.
- I see you have used the
div
&p
elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.
- By using
details
andsummary
elements we can create accessible FAQ toggle feature in a HTML Native way, we don't need to use JavaScript though.
- MDN's reference is a great place to start learning about the
details
andsummary
elements if you are interested.
- If you have any questions or need further clarification, you can always check out
my submission
for this challenge (legacy version) and/or feel free to reach out to me.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
1