FAQ accordion (React)

Community feedback

• 

  P

  Dullahan•290

  @Dullahan83Posted 10 months ago

  Hello :)

  Your Solution looks nice,.

  Neverless, after looking at the preview site and your code, there is 2 principal issues that you could fix pretty easily:

  • You shouldn't use a fixed height for the .faq class in your app.css. The height of this container should be the result of the content + the padding. Because actually, if you close all accordions you will have a blank space at the bottom, and if you open most of them at the same time the content will overflow from the container.

  • You should try to hide the bar below the last accordion. Since you use a classname for said bar, it should be pretty easy to do in css with something like .classname:last-of-type{ display: none;}

  I found back this link that you could use to improve further the accordion for better user experience

  I hope this feedback is helpful

  Happy Coding :)

  Marked as helpful

  1

  ---

  

  P

  Nick•520

  @mrsev17Posted 10 months ago

  @Dullahan83 Thank you very much, i didn't notice in design which was provided about bar in last accordion, now i remove him by conditional render. And also remove fixed height of .faq class. Happy Coding you too :)

  1
• 

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  On semantic HTML

  Hello there, Congratulations on completing this project

  Your solution looks nice

  I have few suggestions that I think might be of interest to you.

  - HTML: Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <div class="app"> with <main class="app">. the main tag should hold the main content of the page so consider correcting that.

  The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div hold no semantic value.

  I hope this feedback is helpful

  Other than that great job

  1