FAQ Accordion - No JS

Community feedback

• 

  somaye beiranvand•220

  @somaye-beiranvandPosted about 2 years ago

  Hi Restu😊

  Great job on the challenge👏

  One advice to improve your solution:

  you can add best practice for menu using one line of jquery, when you click on a menu item the other one would get closed.

  $(document).ready(function () {
    $("details").on("click", function () {
      $(this).siblings().removeAttr("open");
    });
  });
  

  Hope my feedback would be helpful, happy coding.😊

  Marked as helpful

  0

  ---

  

  NRR•520

  @masrestuPosted about 2 years ago

  @somaye-beiranvand Hi, thanks for the advice. Maybe I will add them for some other projects. But I prefer to use no JS on this challenge (it's a bonus, they said) 😊 .

  1

  

  somaye beiranvand•220

  @somaye-beiranvandPosted about 2 years ago

  @masrestu

  if you don't want to use JS you can add scroll bar to the faq part, so when opening the menus the pictures at the left side doesn't change, and your web page looks more professional.

  Tho on my assumption the bonus was related to the use of summary and details instead of using JS for that part and for other things we could use JS, So added this line of code to my own project. 😃

  0

  

  NRR•520

  @masrestuPosted about 2 years ago

  @somaye-beiranvand I will consider that for next challenges I take. Thanks again for the good advice! 😊

  1