Faq accordion main | HTML | CSS | vanilla JS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • When following the BEM naming convention, avoid repeating __ in class names because only one block name is allowed. For instance, the class name .card__list__header__minus__icon doesn't follow the pattern: "block-name__element-name" and includes the block names list, header, minus and icon.

    You can reference an example of this error here: BEM Quick start - Nesting.

  • It's a bit confusing that the entire div with the class faq-card__list__header has a pointer cursor, but the element that triggers the display is the <h2>. To improve user experience and clarity, consider adding the event listener to the entire div container, making it clickable. This way, users won't be confused about where to click, and the interaction will feel more intuitive.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0