Design comparison
Solution retrospective
Hey! This is my new work. My first challenge with JavaScript. I would be glad to any advice :) Any suggestions you might have! Any comments!
Feedback definitely appreciated
Community feedback
- @Nam-HaiPosted over 3 years ago
The accordion menu works fine, so great work for your first encounter with JavaScript.
However, in most cases, accordions menu are closed by default on websites. Futhermore, you could have given the "buttons" the attribute
cursor: pointer;
so the user knows it can interact with them.Also, when every accordions are opened, some go off the card which makes the design feel cheap. You could have either :
- make the card gain height to contain everything when too many menus are opened.
- authorizes only open one menu at a time, and than opening one close the one that was already opened. (I hope i'm clear xD)
Marked as helpful3@Art-wdtPosted over 3 years ago@BlueTompon Hey!
Thanks for your helpful advices.
I will work on this in the future. I completely forgot about the fact that the accordion is closed by default
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord