Design comparison
SolutionDesign
Solution retrospective
Hii, I'm. not sure how to style the images properly so any feedback is appreciated!
Community feedback
- @itsyabaPosted over 2 years ago
Here is a tip if it helps you should make the box img alone and increase the z index and you should make the girl photo inside a container with the faq and set the overflow to hidden for the faq hidden
1 - @tesla-ambassadorPosted over 2 years ago
Hey Chey. This is a very solid solution! Congrats on completing this solution. Here's a few pointers:
- The responsiveness is good but some the image component is not rendered at the mobile and medium sized screen widths. You might wanna just change the flex-direction to
column
instead ofdisplay: none;
then it will appear above thefaq-container
and this will give your card more space. - In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like <main> or <header> or <footer> your need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link Happy Coding and keep up the good work.
1@cheytesPosted over 2 years ago@tesla-ambassador Hey tes, Thanks for the feedback, it helped a bunch. I totally forgot about flex direction!
1 - The responsiveness is good but some the image component is not rendered at the mobile and medium sized screen widths. You might wanna just change the flex-direction to
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord