@pikapikamart
Posted
Hey, awesome work on this one, though the default layout looks like the mobile design which should not be. Did you code this on a wide screen? You must account that there are 1366x767 resolution screen for desktop.
Some suggestions would be:
- Avoid using
height: 100vh
on a large container, this makes the element's height limited to the remaining screen/viewport's height. Instead, usemin-height: 100vh
, this takes full viewport but allows the content to expand if it needs to. Also remove thewidth: 100%
on thebody
tag,block
element like thebody
tag have a defaultwidth: 100%
. - You are missing the cube image on the desktop layout, you might want to check that one out.
- It would be better if the question name can be toggled to show the answer as well. Since you are using
button
for the dropdown icon, you can wrap the question name inside thebutton
so that they will activate it as well. But to be honest, I would just usedetails
element on this one. Since using regularbutton
needs to be manipulated in javascript to make it more accessible for users,details
is already accessible which is great.
Aside from those, great work again on this one. But maybe try to lower down your breakpoint so users won't have to zoom out just to see the desktop layout.
Marked as helpful
@GColville
Posted
@pikamart
Thanks for the pointers!
Lol yeah I'm using widescreen, didn't even think about the breakpoint being what it is, silly mistake!
I did find this one quite difficult, so will be coming back and starting this one from the beginning again once I've done some practice and reading.
Thanks again for the tips :)