Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FAQ Accordion Card

@firhanram

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be great!

Community feedback

@AgataLiberska

Posted

Hi Firhan, the card looks great, well done!

I would suggest minor tweaks:

  • Your card width expands on screens between mobile and around 1024px - that is great. However, towards the higher end of that spectrum it gets quite long. I feel that when it's more than 750px wide, I have to move my eyes from the question to the arrow to take in what's happening, which makes it harder to use. Maybe try to set a max-width on the card in the mobile design to see what you think?
  • Maybe try adding a transition to expanding questions, as an extra challenge :)
0

@firhanram

Posted

@AgataLiberska yes I set the max width, so I just have 1 media query. First, I check the width in inspect element on computed menu. I think I am gonna give a transition. Thanks for your feedback!

0

@AgataLiberska

Posted

@firhanram sorry for not being clear - I didn't mean adding another media query. I was talking about setting a max-width on your card-container class. Just had a look and you have width set to 90%, I would leave that in and just below that property, add max-width set to about 500px. See what you think, and let me know if that makes sense :)

0

@firhanram

Posted

@AgataLiberska when I set max-width to 500px, It gets smaller. So, the choice is to set max-width to 921.6px

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord