FAQ accordion card using vanilla JS with complex image stuff

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi rushinstuffin, I think you're right in saying that using a fixed pixel height and width for sizing is generally a bad idea. There are certain situations where I'd use it, like if I know the element will not change its size whatever no matter the viewport size. The other end of the extreme is when people use percentages like width: 50% for a container to make it responsive, only to see that it becomes barely viewable on screen. I find width: min() to be a useful tool when sizing containers. You can check out this article over on web.dev that talks about responsive properties.

  Two quick suggestions I have for you: Try a higher breakpoint than 375px (maybe around tablet size 600/700px), and try to make the font size bigger. I think ideally you wouldn't want to do anything smaller than 0.75rem.

  Good job with all the positioning though!

  Marked as helpful

  1

  ---

  

  rushinstuffin•380

  @kyle-barry-appsPosted about 2 years ago

  @elaineleung Thanks, again! I really appreciate it :)

  1