Design comparison
Solution retrospective
I coded desktop first, using Sass. My first JS project on Frontend Mentor :)) It was challenging for me to put svg in a pseudo element, but I'm happy & relieved to be able to figure out how it works finally.
I wondered if I should fix the width of the container, either with vw or rem to make it responsible for all the devices and locate svg always at the same location however the container width changes. I used rem this time, but I'm not sure if it was the right practice.
Any feedback and suggestion for improvement would be very much appreciated :)!!
Community feedback
- @janegcaPosted almost 4 years ago
Hi Nafsuki, very nicely done 😊. Only tweak I would suggest is to add a padding of 1 or 2vw to the outside wrapper so things don't stick to screen edges in the smaller widths.
2@NafsukiPosted almost 4 years ago@janegca Thank you very much for the constructive feedback!! I'll do that!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord