FAQ accordion card using HTML5, CSS3, Sass & JS

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…

  • Include description with the alt in image tags, like this line <img class="box" src="images/illustration-box-desktop.svg" alt="" />
  • Remove unnecessary code to keep it clean
  • Instead of using min-width: 23.5rem for the width size in media query, It's much prefer to use the equivalent measurement in pixel.
  • Increase or add another breakpoint starting with 837px for the responsive design
  • Add cursor: pointer; in the accordion state or in ..arrow-container .arrow rule set

  On the contrary:

  • Proper use of semantic tags
  • HTML structure is well organized
  • The design is well implemented
  • Accurate use of details in styling and alignment
  • JS functionality is done properly ( specially the accordion)

  Above all, The design looks good. Keep it up!

  Marked as helpful

  0