FAQ Accordion Card using HTML, SCSS and JS

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @ianbrdeguzman, well done on this challenge!

  If I can point a few things out: I think your media query is perfect, but I would restrict the width of the card when it's in a column layout, I think it would help UX-wise. Just as an example, on an ipad, the card is in a column and it is quite wide, to the point where I need to move my eyes from the question to the arrow that indicates that it's an accordion and can be opened. Maybe not a massive issue, but I think it would look more polished.

  You could also add some transitions to the accordions, so the opening/closing is smoother.

  And the last thing - I'm not sure if using the <header> element is the best choice here, as it is usually introductory content for the page, things like logos, navigation etc. Just something to consider.

  Hope this helps :)

  1

  ---

  

  Ian De Guzman•330

  @ianbrdeguzmanPosted over 3 years ago

  Hey @AgataLiberska! thank you for taking time to write up a feedback really appreciate it. Your right I've added 1 more media break on iPad devices also change header to a div.

  Thank you🙏!

  0