FAQ Accordion Card Solution using Sass, BEM, and Responsive Design

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  Hi, Alex Garcia 🦝 Garcialexco! 👋

  I recommend providing a non-minified CSS for code review. This way, people can easily review the entire stylesheet.

  I would like to suggest some improvements.

  • Use native HTML elements for the accordions by using <details> and <summary> elements. Right now, I can't access the accordions using keyboard.
  • Having a desktop layout at 1440px width is too late. You should make the website using the desktop layout as soon as there is enough space.

  I hope my suggestions help you. Have fun coding! 😄

  Marked as helpful

  2

  ---

  

  Alex Garcia 🦝 Garcialexco•440

  @garcialexcoPosted over 1 year ago

  @vanzasetia Thank you! That helps a lot, I see what you mean about it not being accessible via keyboard. For sure, I will keep that in mind. Thank you very very much for your review! 😄

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 1 year ago

  @garcialexco

  No problem! 👍

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing your first challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • Since this component involves decorative svg's, here those images are only a decoration, so it must have an alt attribute with "" empty value.

  ---

  • Eg: <img src="./assets/images/example-image.svg" alt="">

    ---

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Alex Garcia 🦝 Garcialexco•440

  @garcialexcoPosted over 1 year ago

  @0xAbdulKhalid Thank you very much for your help! I knew I was missing something with those alt tags. I fixed it, and hopefully it is better than it was.

  Thank you again! 😄

  0