Design comparison
Solution retrospective
-
When on horizontal orientation on mobile devices, the height of the whole page is off. What is the best way to resolve this?
-
What would be the simplest and most efficient way to refactor/write the jQuery code I wrote for this solution? Would it involve using "this"?
Thanks in advance!
Community feedback
- @anhduy1202Posted over 3 years ago
Hi, first of all great work ! For your first question, I don't see anything off when I resize it in dev tool, otherwise considering using min/max-height or width with percentages. For the second question, this can be done in Js also, you can check my code out if you want since I'm not familiar with JQuery :D pls like if this is helpful, happy coding!
Marked as helpful1@chungchloePosted over 3 years ago@anhduy1202 Thank you! I will check out your code for reference for sure!
0 - @CodeVeePosted over 3 years ago
Great Implementation. On your second question, no it won't involve the "this" keyword. Query Selectors and looping through a node list will do the trick without the code duplication.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord