Design comparison
Solution retrospective
Hello! I appreciate any feedback on my solution. Thank you!
Community feedback
- @CyrusKabirPosted about 3 years ago
hello my dear friend ♥ you did good at all in functionality (open/close) but you have some problems in design and responsive :
- when you are using flex box in body for centering the card you don't need margin auto in main card it's add a lot of scrolling ( both x and y ) to project if you see
- you need have more @media to control width of your card in different sizes
- for those images are decorative like (svg , arrow down icon , etc) you should put an empty alt="" then add this attr aria-hidden="true" this make screen readers ignore that
Marked as helpful1@CyrusKabirPosted about 3 years ago@CyrusKabir also I notice that in accordion you should let user just open one of them and when click to another one others should be close but in your card we can open all of them and have a lot of changing in card size
1@lisov1yPosted about 3 years ago@CyrusKabir I didn't find any info about what way accordion should work. So I let the user open as many tabs as he wants and the height adapts to it. Or did I miss this info somewhere?
0@CyrusKabirPosted about 3 years ago@lisov1y I didn't fine too but think about that : if you have three or less it's ok but in more accordion it's better to let user just open one if they continue opening all ui of card get destroyed
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord