FAQ accordion card

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  HTML:

  • Try not to use the <main> tag as a component, use it as a container that will wrap the component in question.

  CSS:

  • To fit the frame into the screen and leave space on the sides you could add a padding-left: 25px and padding-right: 25px to the <main> tag, this will prevent the content to touch the side of the screen.

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ACCORDION 🔴 :

  • The best way to go with creating the accordion elements in this challenge would be with the details and summary elements (or perhaps a combination of buttons and other elements).

  ---

  • They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the div & p elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.

  ---

  • MDN's reference is a great place to start learning about the details and summary elements if you are interested.

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0