Skip to content
Submitted over 1 year ago

FAQ accordion card

vjaimes•180
@vjaimes
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

any feedback on code is appreciated!!

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    ACCORDION 🔴 :

    • The best way to go with creating the accordion elements in this challenge would be with the details and summary elements (or perhaps a combination of buttons and other elements).
    • They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the div, span & p elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.
    • MDN's reference is a great place to start learning about the details and summary elements if you are interested.
    • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1
    vjaimes•180
    @vjaimesPosted over 1 year ago

    Was not aware of those elements before this, thanks a lot!! @0xAbdulKhalid

    0
  • Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    Hi, vjaimes! 👋

    I have some feedback on improving your solution:

    • Do not change the <html> or the :root font size: It can cause huge accessibility implications for those users with different font sizes or zoom requirements. Grace Snow explains the issue clearly—Should I change the default HTML font-size to 62.5%?—and Joshua Comeau also does not recommend that approach—The Surprising Truth About Pixels and Accessibility: should I use pixels or rems?.
    • User's preference: Use prefers-reduced-motion to turn off the animations for users that prefer not to see them.
    • Decorative images should not have alternative text: Not every image needs alternative text. This will tell the screen reader to skip over the decorative images. As a result, it saves screen reader users time navigating the page. For your information, decorative images are images that do not add any information and serve only aesthetic purposes.
    • Remove the word "image" from the alternative text: Alternative text for images should not include any words that are related to the word "image". The semantic meaning of the <img> element tells assistive technologies to pronounce it as an image.

    I hope this helps. Happy coding! 🙂

    Marked as helpful
    0
    vjaimes•180
    @vjaimesPosted over 1 year ago

    @vanzasetia very good feedback, thank you very much!!

    0
    Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    @vjaimes Happy to help!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord