Faq accordion card | Using HTML and CSS

Community feedback

• 

  Davide•1,725

  @Da-vi-dePosted about 3 years ago

  Hi Dania, it looks very good, well done! I think the code is well structured and readable, my advice for improvements are:

  • The alt attribute is quite important for no decorative images, it's mandatory for accessibility, screen readers need to know what is in there but also in case the images for any reason can't be loaded.

  • You can change images depending on the width in html thanks to <picture></picture> element. I'll show you how you can do it the next time:

          <picture>
            <source media="(min-width: 900px)" srcset="desktop image goes here">
            <source media="(min-width: 500px)" srcset="tablet image goes here">
            <img src="mobile image goes here" 
                 alt="describe in a few words the image"
                 class="style your image"
            >
          </picture>
  

  • Also i want to encourage you to change approach and start implementing the mobile version first. I'm sure you'll enjoy the benifits of doing that when you'll work on bigger projects.

  Hope it helps a little, keep coding :-)

  Marked as helpful

  2

  ---

  

  dania•530

  @adimidaniaPosted about 3 years ago

  @Da-vi-de I really appreciate your help! thank you soo much, I'll put that in mind

  1