Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FAQ Accordion Card

SudodoSuβ€’ 210

@SudodoSu

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I welcome any valuable insights and guidance regarding optimal strategies for positioning images in a more effective and professional manner. Your expert advice on improving image placement techniques would be highly appreciated.

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

ACCORDION πŸ”΄ :

  • The best way to go with creating the accordion elements in this challenge would be with the details and summary elements (or perhaps a combination of buttons and other elements).
  • They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the div & span elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.
  • MDN's reference is a great place to start learning about the details and summary elements if you are interested.
  • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1
_nehalπŸ’Žβ€’ 6,710

@NehalSahu8055

Posted

Hello Coder πŸ‘‹.

Congratulations on successfully completing the challenge! πŸŽ‰

Few suggestions regarding design.

  • Set a break-point at 1072px for your design i.e; media query.

  • For image like .svg are decorative which browser will not render it to be important and skip it, so it make no sense to add alt leave it blank.

<img src="image.svg" alt="">

  • For positioning of image and all you can refer my solution link.

  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google. link

  • Try to add accessibility features like aria, sr-only, title.

aria : link

.sr-only:link

I hope you find this helpful.

Happy codingπŸ˜„

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord