FAQ Accordion Card HTML/CSS/JS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  Hi There! 👋

  Congratulations on finishing this challenge! 👏

  I have some feedback on this solution:

  • Accessibility
    • Good job on wrapping all page content with main landmark! 👍
    • For the decorative images, leave the alt="" empty instead.
    • I would recommend using HTML native elements (details and summary) to create the accordion. By default, they are accessible so you don't need to do any configuration to make the accordion accessible.
    • Create a custom :focus-visible styling to any interactive elements (button, links, input, textarea). This will make the users can navigate this website using keyboard (by using Tab key) easily.
  • Styling
    • The color of the text should be black instead of purple color.
  • JavaScript
    • I would recommend using querySelectorAll instead of getElementsByClassName. By doing that, it allows you to use forEach instead of for loop and makes your code looks cleaner and modern.

  That's it! Hopefully, this is helpful! 😁

  0
• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great job overall man. Keep it up

  0