Design comparison
Solution retrospective
10/26/20
Honest feedback/criticism is appreciated! Any suggestions on how I can improve this solution?
Credits: https://www.frontendmentor.io/solutions/faq-accordion-card-htmlcss-flexbox-js-Yjw1BKo4Q (JavaScript)
Update 10/27/20
- Removed
display:none;
in the CSS and moved it directly to the answer divs in the index.html. This fixed the double clicking issue.
<div class="answer-div" style="display:none;">
- Reduced opacity of the box shadow
Community feedback
- @OlehTovkaniukPosted about 4 years ago
This is kind of creative solution. I like the box animation. Also the main container's size aren't changing when I open the tabs which is good. Nice work.
1@SarsiPCPosted about 4 years ago@OlehTovkaniuk Glad you like it! Thankyou very much!
JS code isn't actually mine, though. Haha! I gave credit to the user in the desc.
0 - @ApplePieGiraffePosted about 4 years ago
Hey, Dwight! š
Nice job on this challenge! I like how you animated the floating cube upon opening any one of the FAQs! š
Your solution is responsive, too! š
I suggest,
- Decreasing the intensity of the box-shadow a bit (to make it a little more subtle like in the original design).
- For some reason, when I first load the page, I have to click on each FAQ twice in order to open it. You might want to look into your JS to see what's going on.
Keep coding (and happy coding, too)! š
1@SarsiPCPosted about 4 years ago@ApplePieGiraffe I am very new to JS and the code isn't actually mine.
Anyway to fix this?
Thanks for the comment!
0@ApplePieGiraffePosted about 4 years ago@SarsiPC
I'm actually quite new to JS, too! š
While I might not be able to find the exact problem, I vaguely remember having a similar issue in one of my projects where I had to click twice on one of the buttons on my page for a certain popup to appear.
I ended up coming across this StackOverflow answer that explains how JS understands the
display
property. Perhaps this could help! š1@SarsiPCPosted about 4 years ago@ApplePieGiraffe OMG, thanks so much for this! ā¤ļøā¤ļø
Finally fixed the double clicking issue- thanks to you! You should check it out once again.
0@ApplePieGiraffePosted about 4 years ago@SarsiPC
It works great now! š
Good job on the fix! š
š
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord