FAQ Accordion Card Component (HTML, CSS and JavaScript)

Community feedback

• 

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  Hey, congrats on finishing the challenge. The JS in this one looks pretty solid. The beautiful thing about JS is that it can be built in many different ways. So the way you did it would be different than the way I would do it. Both are valid. The results are the same.

  I would try to challenge you to see if you could redo this one with no JS. The accordions could be built out using radio selects and only CSS to show and hide the info.

  Lastly, your FAQ section looks off on mobile. Check out,

  .faq-wrapper {
    overflow: scroll;
  }
  

  Is it needed? It is giving me some weird padding issue on mobile.

  1

  ---

  

  kccodes•125

  @kamilcodesPosted over 3 years ago

  @ericsalvi Thank you for the feedback. I deleted the overflow: scroll. I also double checked the FAQ section on mobile on Safari, Chrome and Firefox and it seems to look and work ok. Can you tell me where you see the padding issue?

  1

  

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  @kamilcodes It is much better now. The overflow was causing some weird misalignment/padding. Since you fixed that the padding issue went away.

  1