FAQ accordion card challenge hub

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @szymKamil 👋🏻

  I have some suggestion to help you fix the accessibility, HTML and some other issues.

  • First, img tags in HTML most of the time have to have alt tags, so in this case it would look like this: <img class="arrow" src="images/icon-arrow-down.svg" alt="arrow">.
  • Also, I'm not sure what type of attribute this is )='' or maybe it's just a typo, but it's causing some errors, make sure to remove it. These recommendations will help you to fix both accessibility and HTML issues, just make sure to generate a new report once you fix the issue.
  • I just mentioned that most of the time img should have an alt tag. Well, there are some cases when they shouldn't have one, but they must have something else instead, and that is aria-hidden. You can read more about aria-hidden here. Below, you can see how they should look like in your markup.

  <img src="images/illustration-box-desktop.svg" aria-hidden="true" id="box" onclick="jump()">
  <img src="images/illustration-woman-online-desktop.svg" aria-hidden="true" id="w-desk">
  

  I hope this was helpful 👨🏻‍💻 nice job for the first time with JS, keep it up. Cheers 👾

  0