Design comparison
Community feedback
- @jonathan401Posted over 2 years ago
Hey @maciejfedor π. Congrats on completing this challenge ππ. You did a really good job π. I have a few suggestions though.
-
Looking through your index.html file I noticed you placed the arrow image in every .item class. This is not considered good practice as you should try to always avoid repeating code βΊοΈ. You could try using the
::after
pseudo selector to place the arrow image after every item class. So it'll look something like :.item::after { content: url (images/icon-down.svg); display: block; width: 1rem; height: 0.6rem; stroke-width: 2px; }
. -
You could also try using the
details
tag along with thesummary
tag to create the faq questions and answers βΊοΈ. You could read about it here.
P.S you could apply the suggestions above in your future projects βΊοΈ. There's no need to change your code it still looks great ππ.You did an awesome job π Happy coding ππ
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord