Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FAQ accordion card

P
Jax Teller 670

@piushbhandari

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


yeah, i didn't get the images working right, but least the accordion is on point

Community feedback

@blockfl0w

Posted

your font awsome script is trying to add tags to your document normally this wouldnt be that much of a problem but because of were you have put your script tags its casuing bad practice problems I would solve this by changing the postion of the `

<body> ```

for more on the defer attribute here is a mdn doc on it this also includes infomation about loading scripts asynchronously with the async attribute

Also your logic in your javascript makes it so there can only be one accordian open at one time it also means that an accordian has to be open at all times which can annoy users. When the website loads it opens the second accordian automatically if its going to open an accordian automatically It should be the first!

0

Elaine 11,400

@elaineleung

Posted

@blockfl0w Good point about the second item being open; I do think however that it's because of the design that Jax chose to do it that way so that his work can match the screenshot. I also did this challenge and I didn't have dropdowns opened (and therefore did not match the screenshot 😅)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord