FAQ accordion card

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Angel Pineda! 👋

  Nice work on this challenge! 🙌

  I think using absolute positioning for the floating cube is a good call since it needs to overlap the accordion card and the outside. The illustration and background image in the desktop layout can be placed with CSS background images, though. Doing so means you won’t have to add those images directly to your HTML (which will keep your markup a little cleaner) and I think it’s easier to manage background images with CSS because you won’t have to worry about things like overflow issues. If you’d like to learn more about CSS background images and how to use them, check out this tutorial from MDN. 🙂

  Besides that, I'd like to suggest,

  • Adding cursor: pointer to the FAQs in the accordion card.
  • Adding a little space between the card and the bottom of the page (using margin/padding) in the mobile layout.
  • Probably adding a little bit of space between the top of the card and the heading, as well.

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  0

  ---

  

  Angel Pineda•215

  @angelpineda-devPosted over 3 years ago

  @ApplePieGiraffe thank you for the comments and the resourcers, this will help me to improve my coding.

  1