FAQ accordion card

Community feedback

• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  You did really good

  Marked as helpful

  0
• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Congrats on completing the challenge, @stfnpczk!

  Your solution looks quite good. Btw, I know how annoying the image part must've been. I struggled a lot with those too when I build this challenge ;)

  Based on what I've seen in your solution, I have a few suggestions / observations:

  • Your card's height expands when you open an accordion. That shouldn't happen. There are multiple approaches to this. Try to find one that will fit in with the rest of the project and not cause any other unexpected issue

  • There's a feature missing in the project. If you have an accordion already open and you click on another one, the accordion that's currently open should close before the other one is opened.

  Marked as helpful

  0
• 

  Ren Ras•420

  @renrasPosted almost 3 years ago

  Great work!

  Things I'd improve on :

  1. add a fixed height to the main div so it doesn't keep moving when you open/close an accordion

  2. animate the accordion

  Marked as helpful

  0