Skip to content
Submitted about 2 years ago

faq accordion card

Maikoke•450
@MaikoCode
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Let me know your comments and advice !?

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Maikoke, Congratulations on completing this challenge!

    I've just opened your live site and I can say that you did a great job putting everything together! There are some tips to improve your solution:

    1.Its really nice that you’ve used some animation and effects! Something to improve the accessibility its to add a media query reducing the motion.The prefers-reduced-motion CSS media feature is used to detect if the user has requested that the system minimize the amount of non-essential motion it uses. Here’s the code for that:

    /* Remove all animations, transitions and smooth scroll for people that prefer not to see them */
@media (prefers-reduced-motion: reduce) {
  html:focus-within {
    scroll-behavior: auto;
  }

  *,
  *::before,
  *::after {
    animation-duration: 0.01ms !important;
    animation-iteration-count: 1 !important;
    transition-duration: 0.01ms !important;
    scroll-behavior: auto !important;
  }
}

    2.To reduce your CSS file and improve the performance of loading your page you can use a tool called CSS minify that reduces the CSS code by removing the unnecessary characters. You can use a VSCode plugin called minify css or this website tool to reduce your code: https://www.toptal.com/developers/cssminifier

    👾My rating for this solution: ⭐⭐⭐⭐⭐

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Maikoke•450
    @MaikoCodePosted about 2 years ago

    @correlucas I really appreciated these useful tips and I will take them into consideration in my projects. Thanks !

    1
  • Adriano•38,290
    @AdrianoEscarabotePosted about 2 years ago

    Hi Maikoke, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    1
    Maikoke•450
    @MaikoCodePosted about 2 years ago

    @AdrianoEscarabote Thanks for these helpful tips. Until now I confess that I did not take into account the semantic role of tags. And I also admit that I really like using divs. In the future I will try to pay more attention to it !

    0
    Adriano•38,290
    @AdrianoEscarabotePosted about 2 years ago

    @MaikoCode happy coding!!

    0
  • Hyron•5,870
    @hyrongennikePosted about 2 years ago

    Hi @MaikoCode,

    Congrats on completing the challenge

    You can center the card by removing the margin bottom on main.

    main {
    margin: 0;
}

    You can also look into only having one accordion open at a time should be simple just looping over all of them and display: none.

    Hope this is helpful

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord