Design comparison
SolutionDesign
Solution retrospective
Let me know if I can improve my hero image container and all the elements in it.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
ID ATTRIBUTE 🛑:
- The
id
attribute uniquely identifies elements on a page. It does not make sense to duplicate anid
.
- Duplicate
id
's can break the accessibility of labels for forms, table header cells, etc.,
- To fix the problem, change an
id
value if it is used more than once to be sure each is unique. Uniqueid
's differentiate each element from another and prevent invalid markup
- Ensures that each element on the page with an
id
attribute has a uniqueid
attribute value.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@justinnveraPosted over 1 year ago@0xAbdulKhalid Hey! Thanks a lot for the feedback. I've changed the duplicate IDs to classes.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord