FAQ accordion card

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Awesome work with this challenge. Looking at your solution, I think you should know the following as well…

  • Instead of div, alternatively wrap the whole content with semantic tags, for HTML structures, refer it with this one Semantics. Like this line <div class="card"> could be wrap with main tag and <div class="attribution"> with footer tag
  • Add cursor: pointer; for the hover state of the arrow icons
  • Try viewing the main image in responsive design, the position is not fixed when the accordion is on default state

  Other than that...

  • The HTML structure is well organized with descriptions
  • Good job in utilizing picture tag in your code
  • The code is clean and readable
  • The Sass files are well structured
  • Regarding the design, the details are well used based on the original design
  • The project is responsive and need some improvement with alignment
  • The JS functionality is working well specially the accordion

  Above all, the project is well implemented. Keep up the good work!

  Marked as helpful

  1
• 

  Mahfoudh Arous•315

  @aladin002dzPosted over 2 years ago

  now, I did implement:

  • cursor: pointer; for accordion items header.
  • Semantic tags.
  • I tried to improve the image position, it was a nightmare to manage it from the beginning 😅. thanks a lot for your excellent feedback!😊🙏

  0