Skip to content
Submitted about 2 years ago

Faq accordion

Vittorio De Lucia•220
@VittorioDL
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I appreciate any suggestion to improve my code! Feel free to tell me what I could have done better. It's been a while since the last challenge. This need more improvement and it's not the final version.

Community feedback

  • David•8,000
    @DavidMorgadePosted about 2 years ago

    Hello Vittorio, congrats on getting the solution for this challenge!

    If I have your permission, I would like to give you a few tips:

    1. You should really add a cursor: pointer to the whole question div, cause it feel strange that text have the pointer cursor but the arrow doesn't have it!

    2. Another thing I noticed is that the arrow image is swapping directions onclick, but they don't go back to the previews direction if you click on them again, only if you click in other question, maybe your JS needs a toggle method there, instead of adding the scale property. Some cool dropdown effect when showing the paragraph would be cool also!

    3. For the html, in my opinion, it would be better semantically to group everything on a section and divide everything on articles.

    Hope my feedback helps you, good job!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord