
Design comparison
Community feedback
- @YacoubDweikPosted 23 days ago
Good job!
I can click at the space between the question and the icon gets changed, weird right?
I think you need to work more on accessibility, You should always use semantic HTML elements, don't use div all the time, you have main section a article nav aside header all these elements you should use them correctly, because div and span are meaningless and we only use them for styling purposes.
To increase accessibility as well, you should learn about ARIA attributes, this is an example of how you would use them in your design:
https://www.accessibility-developer-guide.com/examples/widgets/accordion/_examples/accordion-with-aria/
and here's another one from Bootstrap:
https://getbootstrap.com/docs/5.3/components/accordion/
Why accessibility matters? Because you want to get your website at the top of Google search results right?
keep it up!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord