FAQ Accordion

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 6 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  UTILIZING FOOTER PROPERLY :

  • Currently the attribution element is placed inside the main element, but actually it's need to be placed outside main element. And it needs to be converted into a footer element instead of plain div with no semantic meaning.

  ---

  • The <footer> typically contains information about the author of the section, copyright data or links to related documents. By doing this we use to provide a more precise detail of the structure of our webpage to the browser or screen readers.

  ---

  • Additionally the footer element needs to be placed on the bottom of screen, we can achieve this using absolute positioning property.

  ---

  • Luckily you already used Flex layout of css to center the component, So you just want to add absolute position for <footer> element to place it in bottom of the page

  body {
    position: relative;
  }
  footer {
     position: absolute;
     bottom: 1em;
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Chris Bui•90

  @chrisvn1808Posted 6 months ago

  @0xabdulkhalid Thank you Khalid! Your feedback is great. I really appreciate it. Happy coding!

  0