Design comparison
SolutionDesign
Solution retrospective
What specific areas of your project would you like help with?
I would appreciate any assistance in improving my JavaScript skills. If someone could review my code and provide feedback on whether it is correct, I would be grateful.
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE ACCORDIONS 🔴 :
- The best way to go with creating the accordion elements in this challenge would be with the
details
andsummary
elements instead of using plaindiv
element with no semantic meaning.
- They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the
div
&p
elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.
- MDN's reference is a great place to start learning about the
details
andsummary
elements if you are interested.
- If you have any questions or need further clarification, you can always check out
my submission
for legacy version of this challenge and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@Talika-BajajPosted 7 months agoThank you, @0xabdulkhalid
I will surely look at the elements and try to make my code better.
Thanks again for the insight, I will keep this in mind
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord