Expenses Chart Component with React

Community feedback

• 

  miland sharma•190

  @milandsharmaPosted about 2 years ago

  hi @prabhu this is amazing work one suggestion for you you should try changing the color on click on the day bar replace it with cyan otherwise its an amazing webpage

  Marked as helpful

  0
• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Prabu, congrats on finishing the challenge! pretty good job with react + ts, and also, nice component tree!

  The only things I think you are missing is using some semantics html tag instead of all divs, maybe a header a main tag or some sections would fit perfectly, apart from that, since you need to have one h1 tag on your document, I would probably change the 'Spending last 7 days' from an h2 tag to an h1 to pass the validation.

  Also I would like to recommend you (based on the structure of your project) to use CSS modules, you can also use them with SCSS and it will only give you advantages, cause the structure of your project will be the same, but the classes will be scoped to components and they will prevent any type of style clash or class name repeating! Also checkout styled components that is also a great solution with CSS in JS, and they have a syntax similar to SCSS.

  Hope my feedback helps you!

  Marked as helpful

  0
• 

  Ibrahim San•230

  @ibra-sanPosted about 2 years ago

  Congrates on completing the challenge! Superb work!

  A small suggestion would be making the color of the bar changes depending on the day to show the total expenditure in that day. For example if today is Friday, then the Friday bar should be in Cyan the rest should be in orange.

  Other than that, excellent work and keep on coding!

  Marked as helpful

  0