Submitted almost 2 years ago
Expenses chart component (No Framework / JSON + Vanilla JS)
@kevinburle
Design comparison
SolutionDesign
Solution retrospective
Hello everyone,
in order to display the bar dynamically, it's preferable to use px units or % on the height ? I use px for this project because of the flexbox (card, bar and day), i'm not able to set the height on 100% (otherwise i need to restructure the HTML code). So, i need to use max-height with a specific value in px to determine the 100% of my bar. But i think that isn't a good practice because if i want to change the height of the bar in the CSS, i need to change this hard coded value in the JS..
thanks for your feedback!
Community feedback
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord