Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Expenses Chart Component

@jeremylloyd

Desktop design screenshot for the Expenses chart component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi Jeremy,

Congratulations for 🎉 for completing this challenge, the Chart component looks great, and I like that you used Char.js, I used it too. There are some issues/suggestions want to address:

  1. Even though, you used the correct semantic for the header and the main content, you should also wrap the footer within the footer tag e.g. <footer class="attribution"></footer>
  2. Your HTML is missing the lang attribute e.g. <html lang="en"></html>
  3. Since you used the section tag, you should include a header, anywhere between h2 to h6.

Overall, great work and wish you the best for your future projects so keep coding 👍.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord